Don't lose half of the processor's serial number#708
Merged
Conversation
Before this change, `microcontroller.cpu.uid` returned values where the top 4 bits of each byte were zero, because of an incorrect bitmask used in this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change,
microcontroller.cpu.uidreturned valueswhere the top 4 bits of each byte were zero, because of
an incorrect bitmask used in this function.
Testing performed: Looked at the value on my Trinket M0
Before the fix, the value was shown as
0B050F000E0E0D01000000010500010F, because 4 out of every 8 bits were lost.